convert more warnings in OCaml syntax to ReScript syntax#5468
Merged
Conversation
zth
commented
Jun 25, 2022
cristianoc
reviewed
Jun 25, 2022
| 19 [2m│[0m let arr = [1] | ||
|
|
||
| You forgot to handle a possible case here, for example: | ||
| ({typ: WithPayload(false)}|{typ: Variant}) |
Collaborator
There was a problem hiding this comment.
This looks a little dense.
Aslo, parens probl non needed.
Member
Author
There was a problem hiding this comment.
@cristianoc check the latest commit, what do you think?
cristianoc
approved these changes
Jun 25, 2022
Collaborator
|
Looking great. Merge away when you're happy with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes more pattern matching related warnings/errors from OCam to ReScript syntax: